CHNL-12941: Add badge count instructions to README #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belleklaviyo
changed the title
kennyklaviyo
reviewed
Jan 2, 2025
kennyklaviyo
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
this looks good to me, will you remove the README changes in #244 to avoid conflicts?
mark-piana
reviewed
Jan 2, 2025
README.md
Outdated
| @@ -519,11 +493,24 @@ project setup with the code from the `KlaviyoSwiftExtension`. Below are instruct | |||
|
|
|||
| Once you have these three things, you can then use the push notifications tester and send a local push notification to make sure that everything was set up correctly. | |||
|
|
|||
| #### Badge Count | |||
| > ℹ️ Incrementing badge count support is available in SDK version [4.1.0](https://github.com/klaviyo/klaviyo-swift-sdk/releases/tag/4.1.0) and higher | |||
There was a problem hiding this comment.
To ensure people don't think they can set badge counts in earlier versions, should we say "Setting or incrementing the badge count is available..."
ajaysubra
approved these changes
Jan 6, 2025
ab1470
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To separate out from work originally lumped in with #244
CHNL-12941
To be merged after 4.1.0 release