Fixed opened push not getting called when app is terminated #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaysubra
commented
Jan 19, 2024
| @@ -144,11 +144,8 @@ struct KlaviyoReducer: ReducerProtocol { | |||
| } | |||
| state.initalizationState = .initializing | |||
| state.apiKey = apiKey | |||
| // carry over pending events | |||
There was a problem hiding this comment.
We are now doing this before completing initialization since we know that in certain cases requests may be added state.pendingRequests after this action has completed.
| initialState.queue += queuedRequests | ||
| // For any requests that get added between initilizing and initilized. | ||
| // Ex: when the app is invoked from a push notification after being killed from the app switcher. | ||
| let pendingRequests = state.pendingRequests |
There was a problem hiding this comment.
This is the line that actually fixes the issue. When we don't have this, the requests that are added to state.pendingRequests after the initialization action were erased from state without enqueuing them.
| @@ -441,4 +441,31 @@ class StateManagementTests: XCTestCase { | |||
| try $0.enqueueRequest(request: .init(apiKey: XCTUnwrap($0.apiKey), endpoint: .createEvent(.init(data: .init(event: event, anonymousId: XCTUnwrap($0.anonymousId)))))) | |||
| } | |||
| } | |||
|
|
|||
| func testEnqueueEventWhenInitilizingSendsEvent() async throws { | |||
There was a problem hiding this comment.
Test to validate the solution works.
ndurell
approved these changes
Jan 19, 2024
evan-masseau
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were handling pending requests but when an app is terminated and launched again from a push notification open it triggers the open event and this open event is added to the pending requests since the SDK is not yet initialized (when the app is relaunched after terminating it's initialized again). However, between the SDK going from initializing to initialized the requests that were added to pending requests were ignored which is what was causing the opened push events from not getting enqueued and eventually sent out.
The fix was to just use the pending requests from state and enqueue each of those instead of using the state that was taken from the disk.
Check List
Manual Test Plan
Supporting Materials