remove initializer for setting identifiers in events #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be released as a minor point release first and then removed in upcoming 3.0.0. |
ajaysubra
reviewed
Jan 4, 2024
Co-authored-by: Ajay Subramanya <[email protected]>
ajaysubra
approved these changes
Jan 4, 2024
kennyklaviyo
reviewed
Jan 8, 2024
Comment on lines
+99
to
+101
| identifiers = nil | ||
| self.value = value | ||
| time = environment.analytics.date() |
There was a problem hiding this comment.
shouldn't this be self.identifiers and self.time?
There was a problem hiding this comment.
Not sure I'm totally following but you don't have to use self if it's clear what you are setting. I think I have a swiftlint rule that will remove this but I can try setting it.
evan-masseau
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We no longer want to allow setting identifiers, time, and profile in events. This can create confusing bugs for developers and brings it in line with the Android SDK.
Check List
Manual Test Plan
Supporting Materials