Fixing a user reported crash on device model code

[ajaysubra]

Description

Added a check to the device model code to avoid a reported crash. Checking the size before copying over the data to the pointer.

Check List

• Are you changing anything with the public API?
• Have you tested this change on real device?
• Are your changes backwards compatible with previous SDK Versions?
• Have you added unit test coverage for your changes?
• Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Checked on a test app and device model showed up fine on the server for an iPhone 13 mini.

{
  "SDK Version": "2.3.0",
  "Device ID": "XXXX",
  "Total Price": 10.99,
  "OS Version": "17.1.2",
  "OS Name": "iOS",
  "App ID": "com.klaviyo.testiosforbfcm",
  "Device Manufacturer": "Apple",
  "App Name": "testingKlaviyo",
  "Device Model": "iPhone14,4",
  "App Version": "1.0",
  "Items Purchased": [
    "Hot Dog",
    "Fries",
    "Shake"
  ],
  "SDK Name": "swift",
  "Push Token": "XXX",
  "App Build": "1",
  "$value": 10.99
}

Reproduced the crash by commenting the line where the size is assigned -

[evan-masseau]

did the iphone 13 mini repro the crash?

[evan-masseau]

It looks right. Obvs it'd be great if we could repro the crash too, but IDK if that's possible.

[ajaysubra]

did the iphone 13 mini repro the crash?

Yes.