Fix for SDK stuck in bad state when email or phone number fails API validation

[ajaysubra]

Description

We had a customer open a issue where they pointed out that the app is stuck in a bad state whenever the email or phone number fails validation. This code aims to do two things -

1. If the phone number fails API validation we will erase the state and dequeue this request.
2. If the email is invalid, we do the same, reset the state and dequeue the request.

We try to keep the SDK fairly light weight and dequeue the request vs. trying again.

Check List

• Are you changing anything with the public API?
• Have you tested this change on real device?
• Are your changes backwards compatible with previous SDK Versions?
• Have you added unit test coverage for your changes?
• Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Case 1: Invalid phone number

1. Add an invalid phone number on a test app using the SDK
2. After this request fails, send a event request using a test event
3. This event succeeded vs. it used to fail in the past

Case 2: Invalid email
Same as above except using a invalid email instead of a phone number.

[evan-masseau]

Makes sense to me. I do wonder if we should do anything more than just drop it out of the queue, like emit a warning or error message. I know last spring we did discuss whether to include any kind of phone or email validation and decided to leave that up to the server at the time.

[ajaysubra]

Makes sense to me. I do wonder if we should do anything more than just drop it out of the queue, like emit a warning or error message. I know last spring we did discuss whether to include any kind of phone or email validation and decided to leave that up to the server at the time.

Documenting for viz - We discussed this internally and decided to silently fail for now mainly due to not have targeted error codes from the API. We do at some point expect to retry based on more accurate error codes from the API.

[evan-masseau]

LGTM, were you going to merge in the deque/dequeue branch into this one also?

[ajaysubra]

LGTM, were you going to merge in the deque/dequeue branch into this one also?

Yup, was just going to address Noah comments and then go for the merge. Doing it now.