Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some comments and minor refactors. #125

Merged
merged 11 commits into from
Dec 8, 2023
Merged

Added some comments and minor refactors. #125

merged 11 commits into from
Dec 8, 2023

Conversation

ajaysubra
Copy link
Contributor

Description

Added some comments for readability.

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Supporting Materials

ajaysubra
ajaysubra commented Dec 8, 2023
View reviewed changes
Sources/KlaviyoSwift/APIRequestErrorHandling.swift Show resolved Hide resolved
Sources/KlaviyoSwift/KlaviyoAPI.swift Show resolved Hide resolved
Sources/KlaviyoSwift/KlaviyoState.swift Outdated Show resolved Hide resolved
Sources/KlaviyoSwift/StateManagement.swift Outdated Show resolved Hide resolved
Sources/KlaviyoSwift/StateManagement.swift Show resolved Hide resolved
Sources/KlaviyoSwift/StateManagement.swift Show resolved Hide resolved
@ajaysubra ajaysubra marked this pull request as ready for review December 8, 2023 19:42
@ajaysubra ajaysubra requested a review from a team as a code owner December 8, 2023 19:42
evan-masseau
evan-masseau approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@evan-masseau evan-masseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i especially like the type aliases for readability! Just suggested typo fixes

ndurell
ndurell approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@ndurell ndurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Great catch on the refactors!

ajaysubra and others added 10 commits December 8, 2023 15:17
@ajaysubra @evan-masseau
Update Sources/KlaviyoSwift/KlaviyoState.swift
a0ffa80 
Co-authored-by: Evan C Masseau <[email protected]>
@ajaysubra
Metadata to DeviceMetadata
1f255e3
@ajaysubra
Merge branch 'as/chnl-3841-some-comments-and-refactor' of github.com:…
136138e 
…klaviyo/klaviyo-swift-sdk into as/chnl-3841-some-comments-and-refactor
@ajaysubra @evan-masseau
Update Sources/KlaviyoSwift/StateManagement.swift
e5d4999 
Co-authored-by: Evan C Masseau <[email protected]>
@ajaysubra @evan-masseau
Update Sources/KlaviyoSwift/StateManagement.swift
527ae70 
Co-authored-by: Evan C Masseau <[email protected]>
@ajaysubra @evan-masseau
Update Sources/KlaviyoSwift/StateManagement.swift
329c407 
Co-authored-by: Evan C Masseau <[email protected]>
@ajaysubra @evan-masseau
Update Sources/KlaviyoSwift/StateManagement.swift
eb913f7 
Co-authored-by: Evan C Masseau <[email protected]>
@ajaysubra @evan-masseau
Update Sources/KlaviyoSwift/StateManagement.swift
63e2ba3 
Co-authored-by: Evan C Masseau <[email protected]>
@ajaysubra @evan-masseau
Update Sources/KlaviyoSwift/StateManagement.swift
6ebe07e 
Co-authored-by: Evan C Masseau <[email protected]>
@ajaysubra @evan-masseau
Update Sources/KlaviyoSwift/StateManagement.swift
d999a7d 
Co-authored-by: Evan C Masseau <[email protected]>
@ajaysubra ajaysubra merged commit 8486b7c into master Dec 8, 2023
4 checks passed
@ajaysubra ajaysubra deleted the as/chnl-3841-some-comments-and-refactor branch December 8, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-masseau evan-masseau evan-masseau approved these changes

@ndurell ndurell ndurell approved these changes

@kennyklaviyo kennyklaviyo Awaiting requested review from kennyklaviyo kennyklaviyo is a code owner automatically assigned from klaviyo/mobile-push-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajaysubra @ndurell @evan-masseau