Improve handling of push token / profile updates #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndurell
force-pushed
the
noah/save_identifiers_during_initialization
branch
from
6b1c4ba to
9b6592b
Compare
ndurell
commented
Nov 16, 2023
| @@ -86,9 +86,6 @@ struct KlaviyoReducer: ReducerProtocol { | |||
|
|
|||
| state = initialState | |||
| state.initalizationState = .initialized | |||
| if let request = try? state.buildProfileRequest() { | |||
There was a problem hiding this comment.
We are no longer sending a request after initialization.
ajaysubra
reviewed
Nov 16, 2023
ajaysubra
approved these changes
Nov 29, 2023
Comment on lines
+78
to
+80
| #if DEBUG | ||
| fatalError(msg) | ||
| #endif |
ndurell
force-pushed
the
noah/save_identifiers_during_initialization
branch
from
6aea95d to
eb40c1d
Compare
evan-masseau
approved these changes
Nov 29, 2023
ndurell
force-pushed
the
noah/save_identifiers_during_initialization
branch
from
35ce83d to
4051ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea of this PR is to reduce the number of redundant request to the backend where possible. This PR also ensures that when token data is present that it gets assigned to the correct profile when identifiers change.
Other changes:
Check List
Manual Test Plan
Supporting Materials