Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests by pinning sqlite3 version #434

Closed

Conversation

mattbrictson
Copy link

sqlite3 version 2.0 was recently released. Rails is not yet compatible with 2.x, which caused all of the sitemap_generator integration tests to break.

Fix by pinning sqlite3 to ~> 1.4 in the integration test gemfiles.

sqlite3 version 2.0 was recently released. Rails is not yet compatible
with 2.x, which caused all of the sitemap_generator integration tests
to break.

Fix by pinning sqlite3 to `~> 1.4` in the integration test gemfiles.
@mattbrictson mattbrictson changed the title Fix integration tests by pinning sqlite version Fix integration tests by pinning sqlite3 version May 24, 2024
Copy link

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets the test suite to green! 🟢 Hooray!

@n-rodriguez
Copy link
Collaborator

Hi there! This has been fixed by #437. I pinned sqlite on version ~> 1.5 because ~> 1.4 doesn't work on MacOS.

Thank you!

@n-rodriguez n-rodriguez closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants