3 new security issues (0 max.).
Here is an overview of what got changed by this pull request:
Issues
======
+ Solved 13
- Added 28
Complexity increasing per file
==============================
- Classes/Common/AbstractDocument.php 1
- Resources/Public/JavaScript/PageView/Toolbox.js 7
- Resources/Public/JavaScript/PageView/TableOfContents.js 9
- Resources/Public/JavaScript/PageView/Metadata.js 4
- Resources/Public/JavaScript/PageView/Controller.js 6
- Resources/Public/JavaScript/PageView/Navigation.js 4
- Classes/Controller/DocumentController.php 7
- Classes/Controller/MetadataController.php 1
- Classes/Controller/NavigationController.php 1
Complexity decreasing per file
==============================
+ Resources/Public/JavaScript/PageView/PageView.js -2
See the complete overview on Codacy
Annotations
Check failure on line 442 in Classes/Controller/AbstractController.php
codacy-production / Codacy Static Code Analysis
Classes/Controller/AbstractController.php#L442
Direct use of $GLOBALS Superglobal detected.
Check failure on line 442 in Classes/Controller/AbstractController.php
codacy-production / Codacy Static Code Analysis
Classes/Controller/AbstractController.php#L442
Direct use of $GLOBALS Superglobal detected.
Check warning on line 497 in Classes/Controller/AbstractController.php
codacy-production / Codacy Static Code Analysis
Classes/Controller/AbstractController.php#L497
The use of function intval() is discouraged; use (int) construction instead.
Check notice on line 501 in Classes/Controller/AbstractController.php
codacy-production / Codacy Static Code Analysis
Classes/Controller/AbstractController.php#L501
Closing brace indented incorrectly; expected 8 spaces, found 16
Check notice on line 501 in Classes/Controller/AbstractController.php
codacy-production / Codacy Static Code Analysis
Classes/Controller/AbstractController.php#L501
Line indented incorrectly; expected 8 spaces, found 16
Check notice on line 503 in Classes/Controller/AbstractController.php
codacy-production / Codacy Static Code Analysis
Classes/Controller/AbstractController.php#L503
Line indented incorrectly; expected 4 spaces, found 5
Check warning on line 3 in Resources/Public/Css/Kitodo.css
codacy-production / Codacy Static Code Analysis
Resources/Public/Css/Kitodo.css#L3
Use of !important
Check notice on line 11 in Resources/Public/JavaScript/PageView/Controller.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Controller.js#L11
'dlfController' is defined but never used.
Check notice on line 106 in Resources/Public/JavaScript/PageView/Controller.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Controller.js#L106
'dlfUtils' is not defined.
Check notice on line 106 in Resources/Public/JavaScript/PageView/Controller.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Controller.js#L106
Method 'findFileByGroup' expected no return value.
Check notice on line 30 in Resources/Public/JavaScript/PageView/Metadata.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Metadata.js#L30
'dlfMetadata' is defined but never used.
Check notice on line 106 in Resources/Public/JavaScript/PageView/Metadata.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Metadata.js#L106
Default clause should be the last clause.
Check notice on line 11 in Resources/Public/JavaScript/PageView/Navigation.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Navigation.js#L11
'dlfNavigation' is defined but never used.
Check notice on line 43 in Resources/Public/JavaScript/PageView/Navigation.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Navigation.js#L43
'prevPageNo' is defined but never used.
Check notice on line 296 in Resources/Public/JavaScript/PageView/PageView.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/PageView.js#L296
'dlfViewerFullTextControl' is not defined.
Check notice on line 299 in Resources/Public/JavaScript/PageView/PageView.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/PageView.js#L299
'dlfViewerFullTextDownloadControl' is not defined.
Check notice on line 309 in Resources/Public/JavaScript/PageView/PageView.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/PageView.js#L309
.catch is a syntax error.
Check notice on line 17 in Resources/Public/JavaScript/PageView/TableOfContents.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/TableOfContents.js#L17
'dlfTableOfContents' is defined but never used.
Check notice on line 52 in Resources/Public/JavaScript/PageView/TableOfContents.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/TableOfContents.js#L52
'e' is defined but never used.
Check notice on line 11 in Resources/Public/JavaScript/PageView/Toolbox.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Toolbox.js#L11
'dlfToolbox' is defined but never used.
Check notice on line 69 in Resources/Public/JavaScript/PageView/Toolbox.js
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/Toolbox.js#L69
Expected a default case.
Check notice on line 7 in Resources/Public/JavaScript/PageView/types.d.ts
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/types.d.ts#L7
'ImageDesc' is defined but never used.
Check notice on line 10 in Resources/Public/JavaScript/PageView/types.d.ts
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/types.d.ts#L10
'PageObject' is defined but never used.
Check notice on line 33 in Resources/Public/JavaScript/PageView/types.d.ts
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/types.d.ts#L33
'Loaded' is defined but never used.
Check notice on line 56 in Resources/Public/JavaScript/PageView/types.d.ts
codacy-production / Codacy Static Code Analysis
Resources/Public/JavaScript/PageView/types.d.ts#L56
'PageHistoryState' is defined but never used.