[MAINTENANCE] Add tests for Common package #953
Conversation
oliver-stoehr
force-pushed
the
CommonTest
branch
2 times, most recently
from
5ca0c7e
to
5e2c8de
Compare
sebastian-meyer
changed the title
sebastian-meyer
added
🛠 maintenance
oliver-stoehr
force-pushed
the
CommonTest
branch
from
f1636f0
to
83bb871
Compare
| */ | ||
| public function canPrepareAndSubmit() | ||
| { | ||
| $this->markTestSkipped('Does not work in combination with other tests.'); |
There was a problem hiding this comment.
Hm, a skipped test is quite useless... There should be a way to make this work even in combination with the other tests. Where exactly does the test fail?
There was a problem hiding this comment.
I reenabled the test. It fails on line 55 at the first assert using the SolrSearch object from line 53. I could not find any difference in any variables accesses in the tested SolrSearch::prepare method.
I also switched to a different Solr core, but that didn't change the result.
However I'm not sure about the DocumentRepository passed to the constructor of the SolrSearch – I'm don't fully understand how the DocumentRepository object is created (or maybe reused?).
There was a problem hiding this comment.
I am sorry, but I can't help you with that. Maybe @beatrycze-volk can give more insight into using the DocumentRepository correctly?
There was a problem hiding this comment.
I am sorry, but I can't help you with that. Maybe @beatrycze-volk can give more insight into using the
DocumentRepositorycorrectly?
Actually more suitable person to answer this question would be @chrizzor as he has implemented this class.
|
I fixed the PHPStan issue in |
|
I fixed the test. It looks like some database query were cached, that were necessary to determine the correct solr core. The solr cores are now determined more directly. |
|
Now you only need to update your branch to master and then I can merge it! |
oliver-stoehr
force-pushed
the
CommonTest
branch
from
9af19ad
to
3eb9d12
Compare
No description provided.