[FEATURE] Midi player measure navigation #952
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verovio toolkit new version Properties adjusted View Images and Verovio side by side
sebastian-meyer
changed the title
Make score view compatible with multiview Add sync hover effect for facsimile and score
sebastian-meyer
requested changes
Aug 8, 2023
There was a problem hiding this comment.
I did just a rough first review. Before continuing with a detailed code review, please fix those issues:
- Add
.DS_Storefiles to.gitignoreand don't check those files in. - Check and fix all the Codacy issues.
- Resolve the merge conflicts with
masterbranch. - Separate genuine third-party Javascript libraries from your own code and/or changed files. As a rule of thumb each third-party library should be put in their own directory (like OpenLayers, jQuery, Toastify, etc.) while changed/own files should be placed in the directory of the Controller which uses the file (like PageView, Search, etc.). The reason is that we exclude third-party libraries from our code quality scans because they usually don't comply with our coding guidelines.
# Conflicts: # Classes/Common/MetsDocument.php # Classes/Controller/AbstractController.php # Classes/Controller/PageViewController.php # Configuration/TypoScript/setup.typoscript # Resources/Private/Language/de.locallang.xlf # Resources/Private/Templates/Navigation/Main.html # Resources/Private/Templates/PageView/Main.html # Resources/Public/JavaScript/AudioPlayer/mediaplayer.js # Resources/Public/JavaScript/PageView/PageView.js # Resources/Public/JavaScript/PageView/ScoreControl.js # Resources/Public/JavaScript/PageView/ScoreUtility.js # Resources/Public/JavaScript/PageView/SyncControl.js
… the AbstractController
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
sebastian-meyer
modified the milestones:
Kitodo.Presentation 5.0.0,
Kitodo.Presentation 5.1.0
# Conflicts: # Classes/Common/AbstractDocument.php # Classes/Common/IiifManifest.php # Classes/Common/MetsDocument.php # Classes/Controller/AbstractController.php # Classes/Controller/PageViewController.php # Classes/Controller/ToolboxController.php # Resources/Private/Language/Labels.xml # Resources/Private/Templates/Navigation/Main.html # ext_conf_template.txt # ext_localconf.php
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.