[MAINTENANCE] Complete tests for MetsDocument #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-meyer
added
🛠 maintenance
sebastian-meyer
changed the title
oliver-stoehr
force-pushed
the
MetsDocumentTest
branch
2 times, most recently
from
7ea2218
to
36b3ab0
Compare
oliver-stoehr
force-pushed
the
MetsDocumentTest
branch
from
36b3ab0
to
976425a
Compare
sebastian-meyer
requested changes
Oct 26, 2023
| <mets:fileSec> | ||
| <mets:fileGrp USE="FULLTEXT"> | ||
| <mets:file ID="FULLTEXT_0001" MIMETYPE="application/pdf"> | ||
| <mets:FLocat LOCTYPE="URL" xlink:href="fulltext_0001.xml"/> |
There was a problem hiding this comment.
Is it intentional that this (and FULLTEXT_0002 and FULLTEXT_0004) is not a valid URL? Looks like only the entry for FULLTEXT_0003 is used in the tests which also is the only one with a valid URL.
If we do not need invalid METS for testing, we should fix this and use valid URLs for every FULLTEXT entry.
|
@sebastian-meyer I fixed the URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing tests for MetsDocument class.