Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Add ViewHelper functional tests instead of unit tests. #902

Merged

Conversation

haogatyp
Copy link
Collaborator

@haogatyp haogatyp commented Feb 6, 2023

Instead of unit testing ViewHelpers it is recommended to do functional tests.

@sebastian-meyer sebastian-meyer added 🛠 maintenance A task to keep the code up-to-date and manageable. ⭐ development fund 2022 A candidate for the Kitodo e.V. development fund. labels Feb 7, 2023
@sebastian-meyer sebastian-meyer changed the title Add ViewHelper functional tests instead of unit tests. [MAINTENANCE] Add ViewHelper functional tests instead of unit tests. Feb 7, 2023
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix both Codacy issues and add the default license header to all new files.

@sebastian-meyer sebastian-meyer merged commit 2bcf180 into kitodo:master Oct 26, 2023
6 checks passed
@oliver-stoehr oliver-stoehr deleted the ViewhelperFunctionalTest branch October 26, 2023 12:42
@sebastian-meyer sebastian-meyer linked an issue Feb 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ development fund 2022 A candidate for the Kitodo e.V. development fund. 🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FUND] Add tests and significantly improve test coverage
3 participants