Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Added format unit tests. #894

Merged
merged 8 commits into from
Oct 26, 2023
Merged

[MAINTENANCE] Added format unit tests. #894

merged 8 commits into from
Oct 26, 2023

Conversation

haogatyp
Copy link
Collaborator

Some of the tests fail because the existing code being tested appears to be buggy.

@sebastian-meyer sebastian-meyer changed the title Added format unit tests. [MAINTENANCE] Added format unit tests. Jan 30, 2023
@sebastian-meyer sebastian-meyer added 🛠 maintenance A task to keep the code up-to-date and manageable. ⭐ development fund 2022 A candidate for the Kitodo e.V. development fund. labels Jan 30, 2023
@sebastian-meyer
Copy link
Member

Could you please bring this pull request up to date with master? Alternatively you can allow me to update your branch, then I can do it myself via GitHub most of the time.

@haogatyp
Copy link
Collaborator Author

haogatyp commented Feb 6, 2023

Could you please bring this pull request up to date with master? Alternatively you can allow me to update your branch, then I can do it myself via GitHub most of the time.

I did a rebase onto current master.

@sebastian-meyer
Copy link
Member

@haogatyp Please bring your branch up-to-date with the master branch.

@oliver-stoehr
Copy link
Contributor

@sebastian-meyer the pull request is fixed and updated

@sebastian-meyer
Copy link
Member

Please have a look at the issues reported by Codacy: https://github.com/kitodo/kitodo-presentation/runs/18049153004

@sebastian-meyer
Copy link
Member

Thank you, but there is still one last issue remaining... ;o)

sebastian-meyer
sebastian-meyer requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the filename (see comment) and add the default license header to every PHP file. Just copy and paste from any other code file!

After that we are finally ready for merging!

Tests/Fixtures/Format/modsOriginInfoWithEditionElectonicEd.xml Outdated
@@ -0,0 +1,138 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the file name.

sebastian-meyer
sebastian-meyer approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@sebastian-meyer sebastian-meyer merged commit c4aaf4f into kitodo:master Oct 26, 2023
6 checks passed
@oliver-stoehr oliver-stoehr deleted the FormatUnitTest branch October 26, 2023 06:02
@sebastian-meyer sebastian-meyer mentioned this pull request Oct 26, 2023
Open
@sebastian-meyer sebastian-meyer linked an issue Feb 1, 2024 that may be closed by this pull request
[FUND] Add tests and significantly improve test coverage #781
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-meyer sebastian-meyer sebastian-meyer approved these changes

Assignees

@haogatyp haogatyp

@oliver-stoehr oliver-stoehr

Labels
⭐ development fund 2022 A candidate for the Kitodo e.V. development fund. 🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Milestone
Kitodo.Presentation 5.0.0
Development

Successfully merging this pull request may close these issues.

[FUND] Add tests and significantly improve test coverage
3 participants
@haogatyp @sebastian-meyer @oliver-stoehr