Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Change metadata to keep arrays instead of strings #1339

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

@beatrycze-volk beatrycze-volk commented Sep 19, 2024

This change restores correct displaying of metadata.

Closes #1317

Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the fix for two-level metadata fields by @chrizzor this looks fine!

Classes/Controller/MetadataController.php Show resolved Hide resolved
@sebastian-meyer
Copy link
Member

I am merging this to at least have a fix for "normal" metadata in 5.x branch. But I'll keep #1308 open, because it still won't work for two-level metadata (see my comment above).

Thank you very much for this very important fix, @beatrycze-volk!

@sebastian-meyer sebastian-meyer merged commit 5240b16 into kitodo:master Sep 20, 2024
7 checks passed
sebastian-meyer added a commit that referenced this pull request Sep 20, 2024
@beatrycze-volk beatrycze-volk deleted the fix-metadata branch September 25, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reading of collections from database doesn't work
3 participants