[BUGFIX] Fix for potential security risk related to file include #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatrycze-volk
force-pushed
the
replace-include
branch
from
969a566
to
1bfb337
Compare
|
Maybe I am missing something, but I don't see a critical security issue here. Sure, it's bad form and should be fixed, but it's not security related. There are no user variables involved, so it's not possible to inject malicious code. Or am I wrong? |
beatrycze-volk
force-pushed
the
replace-include
branch
3 times, most recently
from
d140e03
to
d744442
Compare
According to Codacy it is critical security problem: https://app.codacy.com/p/298603/issues/index?resultDataId=131127386721 |
beatrycze-volk
force-pushed
the
replace-include
branch
from
d744442
to
e9e80cc
Compare
beatrycze-volk
force-pushed
the
replace-include
branch
from
e9e80cc
to
1cbb286
Compare
sebastian-meyer
changed the title
sebastian-meyer
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"include" statement detected. File manipulations are discouraged. Statement is not a function, no parentheses are required. Concatenating is forbidden.