Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix configuration for forceAbsoluteUrl property #1239

Merged
merged 4 commits into from
May 31, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

No description provided.

@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label May 31, 2024
@sebastian-meyer
Copy link
Member

What is your reasoning behind making this setting plugin-specific instead of global? If in an environment where absolute URLs are needed, they are needed everywhere, not just in one plugin.
I think the bug here is not that this setting is global, but that it is ignored by most plugins except PageView when generating URLs...

@beatrycze-volk
Copy link
Collaborator Author

It was used as a plugin setting, not the global configuration. Because of that this value in settings array was always empty and always evaluated to false. I have moved it there, so the value can be actually accessed.

I can also solve it other way round: access this value from global configuration and not from settings array. Should it be done that way?

@sebastian-meyer
Copy link
Member

Yes, I think this would be the more consistent solution. Using absolute URLs should be a global setting. Thank you very much!

@beatrycze-volk beatrycze-volk marked this pull request as draft May 31, 2024 12:03
@beatrycze-volk beatrycze-volk marked this pull request as ready for review May 31, 2024 12:09
@sebastian-meyer sebastian-meyer self-requested a review May 31, 2024 13:15
@sebastian-meyer sebastian-meyer merged commit 404c697 into kitodo:master May 31, 2024
7 checks passed
sebastian-meyer added a commit that referenced this pull request May 31, 2024
@beatrycze-volk beatrycze-volk deleted the fix-settings branch May 31, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants