Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Use empty array if wrap for given property doesn't exists #1236

Merged
merged 4 commits into from
May 31, 2024
Merged

[BUGFIX] Use empty array if wrap for given property doesn't exists #1236

merged 4 commits into from
May 31, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

No description provided.

@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label May 31, 2024
sebastian-meyer
sebastian-meyer requested changes May 31, 2024
View reviewed changes
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, the wraps should be arrays, not strings. Or am I missing something?

@sebastian-meyer sebastian-meyer changed the title [BUGFIX] Use empty sorting if wrap for given property doesn't exists [BUGFIX] Use empty string if wrap for given property doesn't exists May 31, 2024
@beatrycze-volk
Copy link
Collaborator Author

If I remember correctly, the wraps should be arrays, not strings. Or am I missing something?

I will look into it

@beatrycze-volk beatrycze-volk marked this pull request as draft May 31, 2024 10:05
@beatrycze-volk beatrycze-volk marked this pull request as ready for review May 31, 2024 14:36
@beatrycze-volk
Copy link
Collaborator Author

@sebastian-meyer you were right, those are arrays :)

@sebastian-meyer sebastian-meyer changed the title [BUGFIX] Use empty string if wrap for given property doesn't exists [BUGFIX] Use empty array if wrap for given property doesn't exists May 31, 2024
@sebastian-meyer sebastian-meyer merged commit 39cee7f into kitodo:master May 31, 2024
7 checks passed
sebastian-meyer added a commit that referenced this pull request May 31, 2024
@beatrycze-volk @sebastian-meyer
[BUGFIX] Use empty array if wrap for given property doesn't exists (#…
2f9da7a 
…1236)

Co-authored-by: Sebastian Meyer <[email protected]>
@beatrycze-volk beatrycze-volk deleted the fix-wrap branch June 3, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-meyer sebastian-meyer sebastian-meyer approved these changes

Assignees

@beatrycze-volk beatrycze-volk

Labels
🐛 bug A non-security related bug.
Projects
None yet
Milestone
Kitodo.Presentation 5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@beatrycze-volk @sebastian-meyer