Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix warnings for undefined array keys in Mods class #1227

Merged
merged 6 commits into from
May 30, 2024
Merged

[BUGFIX] Fix warnings for undefined array keys in Mods class #1227

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f7ddda
Fix warnings for undefined array keys in `Mods` class
beatrycze-volk May 30, 2024
27019f1
Merge branch 'master' into fix-mods
sebastian-meyer May 30, 2024
d4c9c40
[MAINTENANCE] Adjust reading of page uid in controller (#1220)
beatrycze-volk May 30, 2024
3fc8e1d
[BUGFIX] Fix warning for undefined array key page (#1226)
beatrycze-volk May 30, 2024
c23b35a
Fix variable in in empty all
beatrycze-volk May 30, 2024
29d460d
Merge branch 'fix-mods' of https://github.com/beatrycze-volk/kitodo-p…
beatrycze-volk May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Classes/Format/Mods.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ private function getPlaces(): void
if (!empty($places)) {
foreach ($places as $place) {
$this->metadata['place'][] = $place;
if (!$this->metadata['place_sorting'][0]) {
if (empty($this->metadata['place_sorting'][0])) {
$this->metadata['place_sorting'][0] = preg_replace('/[[:punct:]]/', '', $place);
}
}
Expand Down Expand Up @@ -363,7 +363,7 @@ private function getYears(): void
$issued = $year->getIssuedDates();
if (!empty($issued)) {
$this->metadata['year'][] = $issued[0]->getValue();
if (!$this->metadata['year_sorting'][0]) {
if (empty($this->metadata['year_sorting'][0])) {
$yearSorting = str_ireplace('x', '5', preg_replace('/[^\d.x]/i', '', $issued[0]->getValue()));
if (
strpos($yearSorting, '.')
Expand Down