[FEATURE] Scheduler tasks for indexing, reindexing and harvesting of documents

[frank-ulrich-weber]

Pres_01-2023_Solr-Verbesserungen:
A task for optimizing the index will be added when this is merged.

[sebastian-meyer]

@frank-ulrich-weber: Could you please fix the PHPStan and Codacy issues?
Also, I think you need to add typo3/cms-scheduler to composer.json in order for this to work (this should also help with PHPStan).

[frank-ulrich-weber]

At the moment I don't know how to resolve the remaining issues. The PHPStan and the first two Codays issues are correct but specified by the method signature of the scheduler interface. Additionaly I have no idea how to prevent the Cyclomatic Complexity of validateAdditionalFields() in a sensible way. Any hints? Thanks.

[sebastian-meyer]

Suggested change

	return 1;
	return BaseCommand::FAILURE;

[sebastian-meyer]

Suggested change

	use Kitodo\Dlf\Common\Helper;
	use TYPO3\CMS\Core\Messaging\FlashMessage;
	use TYPO3\CMS\Core\Utility\GeneralUtility;
	use TYPO3\CMS\Scheduler\AdditionalFieldProviderInterface;
	use TYPO3\CMS\Scheduler\Controller\SchedulerModuleController;
	use TYPO3\CMS\Scheduler\Task\AbstractTask;
	use TYPO3\CMS\Backend\Tree\Repository\PageTreeRepository;
	use TYPO3\CMS\Core\Database\ConnectionPool;
	use TYPO3\CMS\Core\Database\Connection;
	use Kitodo\Dlf\Common\Helper;
	use TYPO3\CMS\Backend\Tree\Repository\PageTreeRepository;
	use TYPO3\CMS\Core\Database\Connection;
	use TYPO3\CMS\Core\Database\ConnectionPool;
	use TYPO3\CMS\Core\Messaging\FlashMessage;
	use TYPO3\CMS\Core\Utility\GeneralUtility;
	use TYPO3\CMS\Scheduler\AdditionalFieldProviderInterface;
	use TYPO3\CMS\Scheduler\Controller\SchedulerModuleController;

Please import namespaces in alphabetical order for better readibility.

[sebastian-meyer]

Suggested change

	public function saveAdditionalFields(array $submittedData, AbstractTask $task)
	public function saveAdditionalFields(array $submittedData, BaseTask $task)

PHPStan correctly mentions all the calls to undefined methods in this method. That's because you declare $task as being of type AbstractTask, but then call methods which are only defined in BaseTask. I think declaring $task as being of type BaseTask should fix this. (On the other hand this may break the interface compatibility...)