Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Rename getTitledata to getToplevelMetadata #1081

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

beatrycze-volk
Copy link
Collaborator

This name more clearly describes the purpose of this function.

@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Nov 4, 2023
@sebastian-meyer
Copy link
Member

I suppose from a developer's point of view you are right, but getTitledata is not completely wrong since "Titeldaten" is a technical term for the toplevel metadata of an object (i. e. those which would be found in a library catalog).

But since most developers are no librarians I'll accept your pull request. ;o)

@sebastian-meyer sebastian-meyer merged commit a8bc027 into kitodo:master Nov 4, 2023
6 checks passed
@beatrycze-volk beatrycze-volk deleted the titeldata branch November 6, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants