Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix missing pagination between first and last page #1076

Conversation

BFallert
Copy link
Collaborator

@BFallert BFallert commented Nov 3, 2023

Currently still a problem: no summary (...) is formed yet with too many pages. But better all pages then no pages.

Maybe someone has an idea on how to reinstall this functionality.

Currently still a problem: no summary (...) is formed yet with too many pages
@BFallert
Copy link
Collaborator Author

BFallert commented Nov 3, 2023

I moved my discussion about the ... into an issue see #1077

@sebastian-meyer
Copy link
Member

sebastian-meyer commented Nov 4, 2023

Again, this seems to be a case of personal preference. I am hesitant to change the default behavior, because it means that people using the provided templates have to update theirs to keep the old behavior.
But I appreciate your work in providing an alternative display for the pagination. Maybe add your changes only as comments, so that the default behavior isn't changed, but somebody who prefers your pagination style can easily adapt their template by using the commented variant?

@BFallert
Copy link
Collaborator Author

BFallert commented Nov 6, 2023

I cannot fully agree.
The line <f:for each="{pagination.allPageNumbers}" as="page"> contains an error, the variable name is wrong and should be pagination.pages correctly. Without this correction, no output will be made at this point.

I have commented out the line that prevents the duplicate output of the first / last page, as suggested

@sebastian-meyer
Copy link
Member

That makes totally sense! Thank you very much!

@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label Nov 6, 2023
@sebastian-meyer sebastian-meyer changed the title Fix/pagination missing between first and last [BUGFIX] Fix missing pagination between first and last page Nov 6, 2023
@sebastian-meyer sebastian-meyer merged commit 9675da4 into kitodo:master Nov 6, 2023
6 checks passed
@BFallert BFallert deleted the fix/pagination_missing_between_first_and_last branch November 6, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants