Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Display ORDERLABEL as year in the search results if the structure type is year #1005

Merged

Conversation

beatrycze-volk
Copy link
Collaborator

year

@beatrycze-volk beatrycze-volk marked this pull request as ready for review September 4, 2023 09:40
@sebastian-meyer sebastian-meyer added the ⚙ feature A new feature or enhancement. label Sep 27, 2023
@sebastian-meyer sebastian-meyer changed the title Display year in the search result if the structure type is year [FEATURE] Display year in the search result if the structure type is year Sep 27, 2023
@sebastian-meyer
Copy link
Member

sebastian-meyer commented Sep 27, 2023

Originally the idea was to control the display of metadata in list views (i. e. search results) by setting the is_listed switch:


Thus showing/hiding a metadata field could be achieved by simply changing the field's configuration in the backend instead of having to edit the Fluid template. Therefore I would expect the template to just iterate over all metadata fields where is_listed is true and display them all.
What do you think?

@beatrycze-volk
Copy link
Collaborator Author

After checking it out again I have fund out that actually structure year doesn't contain any metadata and that's why solution with is_listed doesn't work correctly there:

year

Can this solution stay or should i change the way how documents with structure year are indexed?

@sebastian-meyer sebastian-meyer changed the title [FEATURE] Display year in the search result if the structure type is year [FEATURE] Display ORDERLABEL as year in the search results if the structure type is year Oct 24, 2023
@sebastian-meyer sebastian-meyer merged commit 9c799c6 into kitodo:master Oct 24, 2023
5 checks passed
@beatrycze-volk beatrycze-volk deleted the display-year-for-newspaper-years branch October 24, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ feature A new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants