Update codacy fixes

Classes/Middleware/Validation.php

@@ -87,7 +87,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
 
         $content = file_get_contents($parameters['url']);
         if ($content === false) {
-            throw new InvalidArgumentException('Error while loading content of "' . $parameters['url'] . '"' , 1724420640);
+            throw new InvalidArgumentException('Error while loading content of "' . $parameters['url'] . '"', 1724420640);
         }
 
         $document = new DOMDocument();

Classes/Validation/AbstractDlfValidator.php

@@ -14,7 +14,7 @@
 
 namespace Kitodo\Dlf\Validation;
 
-use TYPO3\CMS\Extbase\Validation\Exception\InvalidValidationOptionsException;
+use InvalidArgumentException;
 use TYPO3\CMS\Extbase\Validation\Validator\AbstractValidator;
 
 /**
@@ -32,7 +32,6 @@ abstract class AbstractDlfValidator extends AbstractValidator
 
     /**
      * @param $valueClassName string The class name of the value
-     * @throws InvalidValidationOptionsException
      */
     public function __construct(string $valueClassName)
     {
@@ -43,7 +42,7 @@ public function __construct(string $valueClassName)
     public function validate($value)
     {
         if (!$value instanceof $this->valueClassName) {
-            throw new \InvalidArgumentException('Value must be an instance of ' . $this->valueClassName . '.', 1723126505626);
+            throw new InvalidArgumentException('Value must be an instance of ' . $this->valueClassName . '.', 1723126505626);
         }
         return parent::validate($value);
     }

Classes/Validation/DOMDocumentValidationStack.php

@@ -15,7 +15,7 @@
 namespace Kitodo\Dlf\Validation;
 
 /**
- * Implementation of BaseValidationStack for validating DOMDocument against the configured validators.
+ * Implementation of AbstractDlfValidationStack for validating DOMDocument against the configured validators.
  *
  * @package TYPO3
  * @subpackage dlf

Classes/Validation/LibXmlTrait.php

@@ -14,8 +14,8 @@
  * LICENSE.txt file that was distributed with this source code.
  */
 
-trait LibXmlTrait {
-
+trait LibXmlTrait
+{
     /**
      * Add the errors from the libxml error buffer as validation error.
      *
@@ -41,5 +41,4 @@ public function disableErrorBuffer(): void
     {
         libxml_use_internal_errors(false);
     }
-
 }

Classes/Validation/SaxonXslToSvrlValidator.php

@@ -29,7 +29,8 @@
  *
  * @access public
  */
-class SaxonXslToSvrlValidator extends AbstractDlfValidator {
+class SaxonXslToSvrlValidator extends AbstractDlfValidator
+{
 
     private string $jar;
 

Documentation/Developers/Validation.rst

@@ -12,7 +12,7 @@ Validators
 DOMDocumentValidationStack
 --------------------------
 
-``Kitodo\Dlf\Validation\DOMDocumentValidationStack`` implementation of ``Kitodo\Dlf\Validation\BaseValidationStack`` for validating DOMDocument against the configurable validators.
+``Kitodo\Dlf\Validation\DOMDocumentValidationStack`` implementation of ``Kitodo\Dlf\Validation\AbstractDlfValidationStack`` for validating DOMDocument against the configurable validators.
 
 The configuration is an array validator configurations each with following entries:
 
@@ -128,13 +128,13 @@ Following fields are necessary for binding validator or validation stack to the
      :description:              Description
 
    - :field:                    className
-     :description:              Fully qualified class name of validator class derived from ``Kitodo\Dlf\Validation\BaseValidator`` or of validation stack class derived from ``Kitodo\Dlf\Validation\BaseValidationStack``
+     :description:              Fully qualified class name of validator class derived from ``Kitodo\Dlf\Validation\AbstractDlfValidator`` or of validation stack class derived from ``Kitodo\Dlf\Validation\AbstractDlfValidationStack``
 
    - :field:                    configuration
-     :description:              Block of specific configuration of validator. (Only for validator class derived from ``Kitodo\Dlf\Validation\BaseValidator``)
+     :description:              Block of specific configuration of validator. (Only for validator class derived from ``Kitodo\Dlf\Validation\AbstractDlfValidator``)
 
    - :field:                    validators
-     :description:              Blocks of validators or nested validation stacks. (Only for validation stack class derived from ``Kitodo\Dlf\Validation\BaseValidationStack``)
+     :description:              Blocks of validators or nested validation stacks. (Only for validation stack class derived from ``Kitodo\Dlf\Validation\AbstractDlfValidationStack``)
 
 
 TypoScript Example

Tests/Unit/Validation/DOMDocumentValidationStackTest.php

@@ -22,7 +22,7 @@
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 /**
- * Testing BaseValidatorStack with implementation of DOMDocumentValidationStack.
+ * Testing AbstractDlfValidatorStack with implementation of DOMDocumentValidationStack.
  *
  * @package TYPO3
  * @subpackage dlf
@@ -57,7 +57,7 @@ public function testValidatorClassNotExists(): void
     public function testValidatorDerivation(): void
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage("TYPO3\CMS\Extbase\Validation\Validator\UrlValidator must be an instance of BaseValidator.");
+        $this->expectExceptionMessage("TYPO3\CMS\Extbase\Validation\Validator\UrlValidator must be an instance of AbstractDlfValidator.");
         new DOMDocumentValidationStack([["className" => UrlValidator::class]]);
     }
 

Tests/Unit/Validation/XmlSchemesValidatorTest.php

@@ -14,6 +14,7 @@
 
 namespace Kitodo\Dlf\Tests\Unit\Validation;
 
+use DOMDocument;
 use Kitodo\Dlf\Validation\XmlSchemesValidator;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
@@ -74,7 +75,7 @@ public function testValidation(): void
             ["namespace" => "http://www.loc.gov/mods/v3", "schemaLocation" => "http://www.loc.gov/standards/mods/mods.xsd"]
         ]);
 
-        $domDocument = new \DOMDocument();
+        $domDocument = new DOMDocument();
         // Test with empty document
         $result = $xmlSchemesValidator->validate($domDocument);
         self::assertCount(1, $result->getErrors());