Skip to content

Commit

Permalink
Codacy fix
Browse files Browse the repository at this point in the history
  • Loading branch information
chrizzor committed Jun 18, 2024
1 parent 709711b commit c8200eb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions Classes/Common/MetsDocument.php
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ private function processAdditionalMetadata(array $additionalMetadata, \DOMXPath
foreach ($additionalMetadata as $resArray) {
$this->setMetadataFieldValues($resArray, $domXPath, $domNode, $metadata, $subentries);
$this->setDefaultMetadataValue($resArray, $metadata);
$this->setSortableMetadataValue($resArray, $domXPath, $domNode, $metadata, $subentries);
$this->setSortableMetadataValue($resArray, $domXPath, $domNode, $metadata);
}
}

Expand Down Expand Up @@ -725,11 +725,10 @@ private function setDefaultMetadataValue(array $resArray, array &$metadata): voi
* @param \DOMXPath $domXPath
* @param \DOMElement $domNode
* @param array $metadata
* @param array $subentryResults
*
* @return void
*/
private function setSortableMetadataValue(array $resArray, \DOMXPath $domXPath, \DOMElement $domNode, array &$metadata, array $subentryResults): void
private function setSortableMetadataValue(array $resArray, \DOMXPath $domXPath, \DOMElement $domNode, array &$metadata): void
{
$indexName = $resArray['index_name'];
$currentMetadata = $metadata[$indexName][0];
Expand Down
3 changes: 1 addition & 2 deletions Classes/ViewHelpers/IsArrayViewHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ public static function renderStatic(
array $arguments,
\Closure $renderChildrenClosure,
RenderingContextInterface $renderingContext

Check warning on line 35 in Classes/ViewHelpers/IsArrayViewHelper.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

Classes/ViewHelpers/IsArrayViewHelper.php#L35

Avoid unused parameters such as '$renderingContext'.
)
{
) {

Check notice on line 36 in Classes/ViewHelpers/IsArrayViewHelper.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

Classes/ViewHelpers/IsArrayViewHelper.php#L36

Opening brace should be on a new line
$subject = $arguments['subject'];
if ($subject === null) {
$subject = $renderChildrenClosure();
Expand Down

0 comments on commit c8200eb

Please sign in to comment.