Update codacy issue fixes

kitodo · Aug 28, 2024 · 5ff5c49 · 5ff5c49
1 parent bfb9328
commit 5ff5c49
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Classes/Validation/AbstractDlfValidationStack.php b/Classes/Validation/AbstractDlfValidationStack.php
@@ -96,6 +96,9 @@ protected function addValidator(string $className, string $title, bool $breakOnE
      * Check if value is valid across all validation classes of validation stack.
      *
      * @param $value The value of defined class name.
+     *
+     * @throws InvalidArgumentException
+     *
      * @return void
      */
     protected function isValid($value): void

diff --git a/Classes/Validation/SaxonXslToSvrlValidator.php b/Classes/Validation/SaxonXslToSvrlValidator.php
@@ -40,12 +40,13 @@ class SaxonXslToSvrlValidator extends AbstractDlfValidator implements LoggerAwar
     public function __construct(array $configuration)
     {
         parent::__construct(DOMDocument::class);
-
-        if (!isset($configuration["jar"]) || empty($this->jar = GeneralUtility::getFileAbsFileName($configuration["jar"]))) {
+        $this->jar = GeneralUtility::getFileAbsFileName(isset($configuration["jar"]) ?? '');
+        $this->xsl = GeneralUtility::getFileAbsFileName(isset($configuration["xsl"]) ?? '');
+        if (empty($this->jar)) {
             $this->logger->error('Saxon JAR file not found.');
             throw new InvalidArgumentException('Saxon JAR file not found.', 1723121212747);
         }
-        if (!isset($configuration["xsl"]) || empty($this->xsl = GeneralUtility::getFileAbsFileName($configuration["xsl"]))) {
+        if (empty($this->xsl)) {
             $this->logger->error('XSL Schematron file not found.');
             throw new InvalidArgumentException('XSL Schematron file not found.', 1723121212747);
         }