Safely get the next and previous page numbers

kitodo · May 30, 2024 · 42c9f2d · 42c9f2d
1 parent 5bd3ff6
commit 42c9f2d
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Classes/Controller/AbstractController.php b/Classes/Controller/AbstractController.php
@@ -329,6 +329,7 @@ public function __construct()
  * @param PaginatorInterface $paginator
  * @return array
  */
+ //TODO: clean this function
  protected function buildSimplePagination(PaginationInterface $pagination, PaginatorInterface $paginator): array
  {
  $firstPage = $pagination->getFirstPageNumber();
@@ -406,8 +407,9 @@ protected function buildSimplePagination(PaginationInterface $pagination, Pagina
  array_push($pagesSect, ['label' => '...', 'startRecordNumber' => '...']);
  };
 
- $nextPageNumber = $pages[$currentPageNumber + 1]['startRecordNumber'];
- $previousPageNumber = $pages[$currentPageNumber - 1]['startRecordNumber'];
+ // Safely get the next and previous page numbers
+ $nextPageNumber = isset($pages[$currentPageNumber + 1]['startRecordNumber']) ? $pages[$currentPageNumber + 1]['startRecordNumber'] : null;
+ $previousPageNumber = isset($pages[$currentPageNumber - 1]['startRecordNumber']) ? $pages[$currentPageNumber - 1]['startRecordNumber'] : null;
 
  // 'startRecordNumber' is not required in GridView, only the variant for each loop is required
  // 'endRecordNumber' is not required in both views