Remove not needed sanitize for double parameter

It happens already in sanitizeRequestData() function of AbstractController
kitodo · Sep 4, 2023 · 137ef69 · 137ef69
1 parent 109c485
commit 137ef69
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/Classes/Controller/NavigationController.php b/Classes/Controller/NavigationController.php
@@ -58,15 +58,14 @@ public function mainAction()
  if ($this->isDocMissing()) {
  // Quit without doing anything if required variables are not set.
  return '';
+ }
+
+ // Set default values if not set.
+ if ($this->document->getDoc()->numPages > 0) {
+ $this->setPage();
  } else {
- // Set default values if not set.
- if ($this->document->getDoc()->numPages > 0) {
- $this->setPage();
- $this->requestData['double'] = MathUtility::forceIntegerInRange($this->requestData['double'], 0, 1, 0);
- } else {
- $this->requestData['page'] = 0;
- $this->requestData['double'] = 0;
- }
+ $this->requestData['page'] = 0;
+ $this->requestData['double'] = 0;
  }
 
  // Steps for X pages backward / forward. Double page view uses double steps.

diff --git a/Classes/Controller/PageViewController.php b/Classes/Controller/PageViewController.php
@@ -71,10 +71,10 @@ public function mainAction()
  if ($this->isDocMissingOrEmpty()) {
  // Quit without doing anything if required variables are not set.
  return '';
- } else {
- $this->setPage();
- $this->requestData['double'] = MathUtility::forceIntegerInRange($this->requestData['double'], 0, 1, 0);
  }
+
+ $this->setPage();
+
  // Get image data.
  $this->images[0] = $this->getImage($this->requestData['page']);
  $this->fulltexts[0] = $this->getFulltext($this->requestData['page']);

diff --git a/Classes/Controller/TableOfContentsController.php b/Classes/Controller/TableOfContentsController.php
@@ -63,7 +63,6 @@ public function mainAction()
  */
  private function makeMenuArray()
  {
- $this->requestData['double'] = MathUtility::forceIntegerInRange($this->requestData['double'], 0, 1, 0);
  $menuArray = [];
  // Does the document have physical elements or is it an external file?
  if (