Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10200] Add a profile for testing postgresql with testcontainers #2341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmunozfe
Copy link
Member

JIRA: JBPM-10200

Use of this feature: mvn clean install -Ptc-postgres

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@gmunozfe gmunozfe added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Sep 21, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binary persistence-test.jar needs to be commited in Github?

@mareknovotny
Copy link
Member

@gmunozfe could you use an artifact for the test, also is it duplicated here?

@gmunozfe
Copy link
Member Author

binary persistence-test.jar needs to be commited in Github?

Yes, unfortunately, it was already there and the sequence definition on it was not correctly defined

@gmunozfe
Copy link
Member Author

@gmunozfe could you use an artifact for the test, also is it duplicated here?

@mareknovotny I didn't catch your question (not sure if you refer to the present jar as well), could you elaborate more?

@mareknovotny
Copy link
Member

@gmunozfe could you use an artifact for the test, also is it duplicated here?

@mareknovotny I didn't catch your question (not sure if you refer to the present jar as well), could you elaborate more?

yes, adding jar is not really good way, first the dependency is hidden, second what is the source license and source to that jar?

@gmunozfe
Copy link
Member Author

@gmunozfe could you use an artifact for the test, also is it duplicated here?

@mareknovotny I didn't catch your question (not sure if you refer to the present jar as well), could you elaborate more?

yes, adding jar is not really good way, first the dependency is hidden, second what is the source license and source to that jar?

OK, I will work then to modify it. My first approach was to keep it close as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants