Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-roadmap#52] Improve LogCleanupCommand, do not delete RequestInfo and ErrorInfo records of active process instances #2282

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

martinweiler
Copy link
Contributor

Thank you for submitting this pull request

kie-roadmap-52

Running LogCleanupCommand with parameter OlderThanPeriod=xd removes inactive records from RequestInfo and ErrorInfo even if the related process instance is still active. These entries should not be deleted as long as the process instance is active, as this breaks the ability to reschedule a failed job. Records for active process instances might also be needed for audit purposes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@martinweiler martinweiler requested review from porcelli and elguardian and removed request for elguardian and porcelli February 15, 2024 17:40
Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinweiler martinweiler added the backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch label Mar 19, 2024
@martinweiler martinweiler changed the base branch from main to 7.67.x-blue March 19, 2024 19:08
@martinweiler martinweiler changed the base branch from 7.67.x-blue to main March 19, 2024 19:08
Copy link

Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@gmunozfe gmunozfe added the backport-7.67.x Generate backport PR for 7.67.x branch label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants