Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBPM-9884 Dont allow to modify process variable of type Integer/Boole… #2013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JBPM-9884 Dont allow to modify process variable of type Integer/Boole… #2013

wants to merge 1 commit into from

Conversation

bxf12315
Copy link
Member

@bxf12315 bxf12315 commented Sep 7, 2021 •
edited
Loading

…an/..etc with invalid values through business-central console.

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

https://issues.redhat.com/browse/JBPM-9884

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

How to retest this PR or trigger a specific build:

  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@bxf12315
Copy link
Member Author

bxf12315 commented Sep 7, 2021

Jenkins run fdb

@bxf12315 bxf12315 requested a review from nmirasch September 7, 2021 01:58
@bxf12315 bxf12315 force-pushed the JBPM-9884 branch 2 times, most recently from c3d9c29 to faf0482 Compare September 7, 2021 16:08
@bxf12315
Copy link
Member Author

bxf12315 commented Sep 8, 2021

Jenkins retest this

@bxf12315
Copy link
Member Author

bxf12315 commented Sep 8, 2021

Jenkins run fdb

@bxf12315
Copy link
Member Author

bxf12315 commented Sep 8, 2021

Jenkins run fdb

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bxf12315
Copy link
Member Author

bxf12315 commented Sep 8, 2021

Jenkins run fdb

4 similar comments
@bxf12315
Copy link
Member Author

bxf12315 commented Sep 9, 2021

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

nmirasch
nmirasch reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@nmirasch nmirasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bxf12315 I've added some comments on the validation code and could you mind add some testing, Thanks!

jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/IntegerDataType.java Outdated Show resolved Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/BooleanDataType.java Show resolved Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/FloatDataType.java Outdated Show resolved Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/IntegerDataType.java Outdated Show resolved Hide resolved
@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315 bxf12315 requested a review from prashuts October 21, 2021 12:57
@bxf12315
Copy link
Member Author

Jenkins run fdb

2 similar comments
@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315 bxf12315 force-pushed the JBPM-9884 branch 2 times, most recently from d941bfa to 06d6494 Compare October 25, 2021 04:40
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 5 Code Smells

56.5% 56.5% Coverage
37.5% 37.5% Duplication

@bxf12315
Copy link
Member Author

bxf12315 commented Nov 1, 2021

Jenkins run fdb

3 similar comments
@bxf12315
Copy link
Member Author

bxf12315 commented Nov 3, 2021

Jenkins run fdb

@prashuts
Copy link

prashuts commented Nov 8, 2021

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
JBPM-9884 Dont allow to modify process variable of type Integer/Boole…
6afc6fc 
…an/..etc with invalid values through business-central console.
@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315 bxf12315 requested a review from jstastny-cz December 14, 2021 13:58
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 5 Code Smells

56.5% 56.5% Coverage
37.5% 37.5% Duplication

@bxf12315 bxf12315 mentioned this pull request Dec 20, 2021
Closed
@bxf12315
Copy link
Member Author

Jenkins run fdb

5 similar comments
@nmirasch
Copy link
Contributor

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

bxf12315 commented Jan 3, 2022

Jenkins run fdb

@jstastny-cz jstastny-cz removed the request for review from prashuts January 3, 2022 12:36
@bxf12315
Copy link
Member Author

Jenkins run fdb

3 similar comments
@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

nmirasch
nmirasch requested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@nmirasch nmirasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bxf12315 Code looks good. The only that remains is to remove an unused import and add some unit testing for verifyDataType, passing different values for each modified DataType and validating that passing string representation of basic type value is allowed.

jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/FloatDataType.java
@@ -20,6 +20,7 @@
import java.io.ObjectInput;
import java.io.ObjectOutput;

import org.apache.commons.lang3.StringUtils;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bxf12315 this unused import needs to be removed

@bxf12315
Copy link
Member Author

Jenkins run fdb

1 similar comment
@bxf12315
Copy link
Member Author

Jenkins run fdb

@jstastny-cz jstastny-cz removed their request for review August 23, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmirasch nmirasch nmirasch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bxf12315 @prashuts @nmirasch