Use the new shadcn sidebar across all pages in Khoj #1013
Conversation
- Use the sidebar across all pages to quickly navigate through the app, access settings, and go to past chats - Pending: mobile friendliness
There was a problem hiding this comment.
The settings page seem to have too much outer horizontal padding. Agents and Automations page cards have the same and lower padding. It'd be great if we can align the settings page to have the same padding as the Agents and Automation pages for consistency
| {open ? ( | ||
| <SidebarMenuButton> | ||
| <a className="p-0 no-underline" href="/"> | ||
| <KhojLogoType className="h-auto w-16" /> |
There was a problem hiding this comment.
The Khoj lantern logo drops in size when the sidebar is in collapsed state. Feels like it being the same size but removing the "Khoj" text following it will feel less jittery
There was a problem hiding this comment.
The chat body width seems to have become variable. When ask a question on home page the chat page is loaded with a much smaller width for chat body and chat input footer. This expands based on width of train-of-thought and Khoj response. Keeping width static like before would be better
There was a problem hiding this comment.
It'd be good if sidebar open/close state can be persisted as we move across the app. Currently it seems to open every time we jump between pages
| </SidebarGroup> | ||
| </SidebarContent> | ||
| <SidebarFooter> | ||
| <NavMenu sideBarIsOpen={open} /> |
There was a problem hiding this comment.
It'd be good if the Sidebar footer is given more vertical space. It seems a bit too confined right now
| <p className="ml-3 font-semibold">Releases</p> | ||
| <div className="flex flex-rows text-left content-start justify-start items-start p-0"> | ||
| <ArrowRight className="w-6 h-6" /> | ||
| <p className="ml-3 font-semibold">Login</p> |
There was a problem hiding this comment.
Menu still shows Logout for logged out user instead of Login
There was a problem hiding this comment.
Clicking an automation suggestion card crashes the web app (at least for non logged in user)
There was a problem hiding this comment.
Opening automation page for not logged in user crashes app
There was a problem hiding this comment.
Clicking search page in not logged in state leads to the old login.html page. Should we not make them use the new login popup experience as well?
There was a problem hiding this comment.
Clicking chat with agent (paper plane) button takes to old login page. Should we not guide them to new login popup experience?
Use the shadcn sidebar across Khoj and standardize how the side panel experience works across the app. This helps us generalize the code better, while re-using the same components.
Deprecates current usage of the chat history side panel, replacing it with the new
appSidebar.tsxcomponent.We'll eventually move out the
Manage Filessection and move it into a separate panel dedicated to chat-level controls.