waddy: case insensitive search bar #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanghugo
reviewed
Sep 21, 2024
src/gui/programs/waddy.rs
Outdated
| self.instances[instance_index] | ||
| .search | ||
| .text | ||
| .to_lowercase() |
There was a problem hiding this comment.
Pull the whole self.instances[instance_index].search.text.lowercase() outside of the loop so that it is not calculated many times over.
khanghugo
reviewed
Sep 21, 2024
src/gui/programs/waddy.rs
Outdated
Comment on lines
545
to
549
| let search_text = if is_search_enabled { | ||
| self.instances[instance_index].search.text.to_lowercase() | ||
| } else { | ||
| String::new() | ||
| }; |
There was a problem hiding this comment.
This might be redundant. Just convert to lowercase without any conditions. Search text always have a valid string and empty string is a valid string.
src/gui/programs/waddy.rs
Outdated
| // split into two steps because of rust | ||
| let filtered_tiles = (0..count) | ||
| .filter(|&texture_tile| { | ||
| if is_search_enabled { | ||
| if is_search_enabled && !search_text.is_empty() { |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is probably a better and optimal way to do this, but it works