Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EBDT and EBLC table support. #273

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

mmulet
Copy link

@mmulet mmulet commented Jan 31, 2024

This pull request adds basic parsing and validation for EBDT and EBLC tables in order to support bitmap fonts issue #200 .

It's been tested against the batang.ttc and guilm.ttc fonts supplied with the Korean Supplemental fonts in windows (after some small modifications to get the batang.ttc and guilm.ttc fonts to pass GSUB and CMAP sanitization). Those fonts
used Image formats 2 and 7 and EBLC index subtables 3 and 1. I'm still looking for other fonts that utilize the other index and image formats for testing.

Also, tested agains msmincho.ttc. which used subtable 2 and format 5.

Here is a list:

Tested fonts:

  • msmincho.ttc
  • batang.ttc
  • gulim.ttc
  • lucon.ttf
  • msgothic.ttc
  • simsun.ttc
  • simsunb.ttf
Subtable Index format Tested with production font
1. YES
2. YES
3. YES
4. YES
5 YES
Bitmap Image format Tested with production font
1. YES
2. YES
3. N/A
4. N/A
5. YES
6 NO
7 YES
8 YES
9 YES

Let me know what else has to be done to support bitmap fonts.

Michael Mulet added 6 commits January 30, 2024 13:28
omission of some index subtables when there were multiple
tables per size.
@dimdenGD
Copy link

dimdenGD commented Jul 8, 2024

Could someone review/merge this? It'd be great to add support for bitmap fonts.

@mmontag
Copy link

mmontag commented Oct 23, 2024

@khaledhosny friendly ping

@khaledhosny
Copy link
Owner

It is a quite some code and I don’t have much time to review it currently. But a first step would to provide a set of test fonts that we can add to the test suite, otherwise it is a big chunk of untested code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants