Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build #299

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Fix docker build #299

merged 2 commits into from
Apr 14, 2024

Conversation

AlmarAubel
Copy link
Contributor

Summary

This pull request addresses a critical issue where the backend Docker image was failing to build correctly. The root cause was traced back to the recent update involving directory.build.props and related files, which were not being included in the Docker image(s).

Details

  • directory.build.props Missing directory.build.props and related files in build process of docker images
  • Removed old project BuildingBlocks/EventBus/CompanyName.MyMeetings.BuildingBlocks.EventBus.csproj was still referenced in the build project which was removed during the upgrade to .net 8
  • Issue with Package References: In the API project, the package references included the PrivateAsset="All" flag. This was preventing dotnet pack from copying necessary files, leading to the build issue.
  • DB Migrator Context Adjustment: The Docker build context for the DB Migrator was set to ./src/database. This limited its access to files located at the root of ./src during the Docker build. I've adjusted the context to resolve this issue.
  • Compatibility with ARM-based MacBooks: Added platform: linux/amd64 to the mymeetingsdb container. This change ensures compatibility with ARM-based MacBooks (M1/M2), aiding in broader development support.

Suggested Documentation Update

Given the compatibility enhancement for ARM processors, I recommend we include a link in the README to guide users on configuring Docker to run SQL Server on ARM architectures. This will be particularly helpful for those using newer MacBook models.

Conclusion

These changes should resolve the backend en dbmigrator Docker image build issues and improve our project's compatibility across different development environments. I welcome any further suggestions.
In order to prevent breaking the docker images I created this issue #298

@kgrzybek kgrzybek merged commit 0f3557a into kgrzybek:master Apr 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants