Use UUIDv4 for item IDs to prevent collisions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous solution of using an incrementing integer would result in collisions between items stored in state and beams, since beam IDs are generated on the fly and not stored in state, and the unique ID was only incremented when the ID was not stored in state. This makes item IDs a little harder to read, but ensure they remain unique across all items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous solution of using an incrementing integer would result in collisions between items stored in state and beams, since beam IDs are generated on the fly and not stored in state, and the unique ID was only incremented when the ID was not stored in state. This makes item IDs a little harder to read, but ensure they remain unique across all items.