chore(web): removes unused locals, imports, and private fields 馃敥 #11460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
|
Can you include a reference for why this is being done? (It's part of a larger task, right?) |
mcdurdin
approved these changes
May 17, 2024
common/web/gesture-recognizer/src/test/auto/headless/gesturePath.spec.ts
Outdated
Show resolved
Hide resolved
common/web/gesture-recognizer/src/test/auto/headless/gesturePath.spec.ts
Outdated
Show resolved
Hide resolved
ermshiperete
approved these changes
May 22, 2024
jahorton
force-pushed
the
chore/web/fix-implicit-this
branch
from
eef8c32
to
a5c10e8
Compare
jahorton
force-pushed
the
chore/web/remove-unused-locals
branch
from
4e2ab0c
to
cd3e4ea
Compare
jahorton
changed the base branch from
chore/web/fix-implicit-this
to
fix/web/worker-prediction-match-token
jahorton
changed the title
jahorton
force-pushed
the
chore/web/remove-unused-locals
branch
from
93b0121
to
82db2c6
Compare
jahorton
force-pushed
the
chore/web/remove-unused-locals
branch
from
82db2c6
to
50a194a
Compare
jahorton
changed the base branch from
fix/web/worker-prediction-match-token
to
fix/web/banner-swap-cleanup
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
3 similar comments
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #11473, correcting all errors and warnings that resulted when enforcing
"noUnusedLocals"across all Keyman Engine for Web related code.@keymanapp-test-bot skip