chore(web): conversion of Web's browser-integration auto-tests for @web/test-runner use 🏃 #11455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r 'dom' integration tests
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
commented
May 15, 2024
There was a problem hiding this comment.
This is the test file that hops from web/src/test/auto/integrated into web/src/test/auto/dom.
jahorton
commented
May 16, 2024
Comment on lines
-52
to
-60
| function get_default_browser_set() { | ||
| if [[ $BUILDER_OS == mac ]]; then | ||
| BROWSERS="--browsers Firefox,Chrome,Safari" | ||
| elif [[ $BUILDER_OS == win ]]; then | ||
| BROWSERS="--browsers Firefox,Chrome" | ||
| else | ||
| BROWSERS="--browsers Firefox,Chrome" | ||
| fi | ||
| } |
There was a problem hiding this comment.
Source of the current build failure:
./test.sh: line 80: get_default_browser_set: command not found
Looks like I rebased this deletion a bit too early, so the CI check for this PR falls over here. It's fine as of the next PR in the chain though - #11456 passed its checks.
jahorton
commented
May 16, 2024
There was a problem hiding this comment.
Note: /web/build.sh was not adjusted to include install playwright as part of its configure.
Reasons:
- It currently doesn't have its own
configureaction - it has child projects for that. - It and its child projects (
engine/osk) have dependencies on projects that do haveconfigureactions that'll run it anyway.
mcdurdin
approved these changes
May 21, 2024
ermshiperete
approved these changes
May 22, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.42-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also known as web/src/test/dom, since that's its current name.
All the fixture work related to these tests makes for quite a number of changed lines, but fortunately there are pretty strong patterns throughout.
Also of note: I moved one of the tests from the "end to end" style tests into this section, as it's all about "wrapping" specific types of context-supporting elements with our
OutputTargetabstraction. Now that we have a better setup for running these against all main browser engines, that set of tests fits better here.@keymanapp-test-bot skip