Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for remote loading and saving. #811

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

Improve support for remote loading and saving.

  • _support_gcs_uri did not work for saving APIs. It would create a temp folder, but the file created in the temp folder would never actually be copied to the remote path. Introduced a SupportWriteToRemote, a context manager that copies the temp file to remote on exit and cleans up the temp folder.
  • there were several different places handling remote loading, but none of them would clean up the temp folders created. Introduced a SupportWriteToRemote, a context manager that copies the remote file to a temp folder and cleans up on exit.
  • removed ad-hoc support for remote zip file saving, instead, this is handled the same way as other remote saving cases with a temp file, which removes the memory requirement.

@copybara-service copybara-service bot force-pushed the test_700043742 branch 2 times, most recently from 9d46c94 to cdc773b Compare November 27, 2024 16:54
@copybara-service copybara-service bot closed this Nov 27, 2024
@copybara-service copybara-service bot deleted the test_700043742 branch November 27, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant