Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at porting the flexoki colour scheme to the foot terminal.
I'm marking this as draft because I only ported the dark variant so far and I also wanted to ask if the colours were used properly, after seeing different ports to different terminals seemingly using the colours in different ways. I've included a screenshot of the alacritty port from the repo (the repo doesn't have screenshots of it) which is why I questioned the way I used the colours. Other ports to terminal emulators have screenshots already, and use the colours differently as well.
I've tried sticking to the recommended mappings from the website and not stray away from them.
This foot port:
The alacritty port currently in the repo:
I personally like the darker background used in my port (colour $black) and in other terminal ports, but I'd rather ask whether you'd prefer the colour palette being used differently.
Depending on how strict you are with all ports looking uniform, possibly deciding on a single terminal colour palette and reviewing all the terminal ports accordingly might be desirable.
Waiting for feedback.
Thanks for your time and work, take care.