Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade target to ES2023 #15

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Downgrade target to ES2023 #15

merged 1 commit into from
Dec 3, 2024

Conversation

billyjanitsch
Copy link
Contributor

esbuild (used internally by Vite) has trouble parsing a tsconfig when target is set to ES2024. I've PRed a fix (evanw/esbuild#3990) but not sure if it will be merged/released.

target affects two things: the lib defaults (which we've already overridden in #12) and the transpiler output. We generally don't use the TS transpiler anyway so let's just downgrade target to avoid the Vite issue.

@billyjanitsch billyjanitsch requested a review from a team as a code owner December 3, 2024 20:47
@billyjanitsch billyjanitsch merged commit 779c806 into main Dec 3, 2024
2 checks passed
@billyjanitsch billyjanitsch deleted the es2023 branch December 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant