Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add several missing functions and fix file_exists error #29

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

laurensschuitemaker
Copy link

Each pull request should address a single issue and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Component(s) with PHPDocs
  • Unit testing, with >85% coverage
  • Document updated
  • Conforms to coding standard

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345)
  • Unsolicited pull requests will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

@laurensschuitemaker laurensschuitemaker changed the title Add several missing functions Add several missing functions and fix file_exists error Aug 31, 2023
@kenjis kenjis added the enhancement New feature or request label Sep 1, 2023
@kenjis kenjis changed the title Add several missing functions and fix file_exists error feat: Add several missing functions and fix file_exists error Sep 1, 2023
@kenjis
Copy link
Owner

kenjis commented Sep 1, 2023

What is the file_exists error?

Could you write test code?

@kenjis
Copy link
Owner

kenjis commented Sep 1, 2023

I updated the 1.x branch, and now all GitHub Action checks pass.
Please update your PR branch with git rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants