Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of indent/swift.vim from Aaron Bohannon #115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

morefun2compute
Copy link

No description provided.

@keith
Copy link
Owner

keith commented Feb 7, 2017

Sorry, just getting around to testing this now!

@keith
Copy link
Owner

keith commented Feb 21, 2017

@morefun2compute sorry about that, finally got a chance to check this out and I noticed a few things that I had questions about.

  1. For parentheses continuations such as:
Foo(bar: baz,
    second: thing)

Xcode aligns the second line with the column of the paren +1, do you think that would make sense to do here too instead of doing previous statement + const? This applies to multiline function definitions as well.

  1. I think the defaults might make more sense as 1 * shiftwidth() for most of these, it surprised me to see a statement like this:
if let foo = bar,
    let baz = qux
{

Have the second line be indented by 2 * shiftwidth(). I'm not sure there are any cases where I would use more than shiftwidth() number of spaces more than the statement above.

  1. I noticed that when there's an opening brace with a paren, the closing brace is indented at previous statement + sw instead of just the same indent as the previous statement:
foo({
    }

Do you think any of these things are feasible / worth it to change?

@keith
Copy link
Owner

keith commented Mar 13, 2017

Any thoughts @morefun2compute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants