Print Electrum URL in the logs #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the recent changes in tbtc-v2 project, at least 11 accounts are required in the local Ethereum client keystore to deploy and initialize contracts. The v1Redeemer set in tbtc-v2 hardhat.config.ts uses index 10 and indexes start from 0.
Unless specified in the config, mainnet client binary selects Electrum server from one of the preconfigured nodes. It is nice to know which server was selected, even for debug purposes.
nkuba
reviewed
Jun 1, 2023
We are not logging Ethereum server URL and we expect it to be set in the configuration. For Electrum server, we use a similar behavior now. When it is set in the configuration, we are not logging it. When it is auto-selected from the servers hardcoded in the binary, we print it to logs in the config logger. I have also moved the log informing about Ethereum network to the config level and added there information about Bitcoin network.
tomaszslabon
previously approved these changes
Jun 5, 2023
nkuba
reviewed
Jun 5, 2023
nkuba
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless specified in the config, mainnet client binary selects the Electrum server from one of the preconfigured nodes. It is nice to know which server was selected, even for debugging purposes. Additionally, we should log both Bitcoin and Ethereum networks used by the client. Electrum server URL is printed to the logs only if it has been auto-selected. This approach is consistent with not logging Ethereum server URL at all given we expect it is passed in the configuration.
I snaked one more change in this PR: fixed the number of accounts requirement in
scripts/install.sh. Given the recent changes in tbtc-v2 project, at least 11 accounts are required in the local Ethereum client keystore to deploy and initialize contracts.The
v1Redeemerset in tbtc-v2hardhat.config.tsuses index 10 and indexes start from 0.Example: