Not running govet or gofmt in Dockerfile builds #1283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have code quality checks on the
v2
branch, they will run prior to any docker build operation. That means that thego fmt
andgo vet
calls inside the Dockerfile are redundant. This change removes them by creating two new makefile targets:adapter-dockerfile
andmanager-dockerfile
, and changing the adapter and manager dockerfiles to call those two targets, respectively.This patch also adds
go vet
to the pre-commit config file.Question: should we add go vet to the golangci config file? This way, we can avoid running
go fmt
andgo vet
explicitly in the pre commit file, as it'll be done automatically by the pre-commit golangci hookChecklist
Fixes #1070
Notes about TODOs:
Not sure about the changelog