-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add a flag to crd-puller to specify only the required CRDs that needs to be synced #840
✨ Add a flag to crd-puller to specify only the required CRDs that needs to be synced #840
Conversation
I think the path forward is to delete cmd/crd-puller from the repo. Thoughts @sttts @stevekuznetsov @davidfestal? |
Would wait for the API management epic to unfold. There we need something like crdpuller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long on this one - are you still interested in getting this merged? If you can make these changes, we can get it in! Thanks!
253ba30
to
f560fe9
Compare
@ncdc PTAL. I have worked on all the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These diffs should make it work without the need for an extra variable
/test all |
f560fe9
to
9c72ed6
Compare
@ncdc Done. PTAL. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
…ds to be synced Signed-off-by: Andy Goldstein <[email protected]>
Fixed the imports |
/lgtm |
Going to close and reopen to get Prow to do all the tests |
/test all |
kcp-dev/contrib-tmc#93 |
Summary
Provide an additional flag (--resources-to-sync) to specify which CRDs the user wants to pull.
Note: If the flag is not used or is empty, the default behavior(pull all CRDs on the cluster) is followed.
Typical usage is as shown below:
go run cmd/crd-puller/pull-crds.go --kubeconfig /home/bnr/.kube/config --resources-to-sync "pods,services,deployments"
Related issue(s)
#839
Fixes #839