Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add version to kubectl-workspace #3135

Merged
merged 1 commit into from
May 20, 2024
Merged

✨ Add version to kubectl-workspace #3135

merged 1 commit into from
May 20, 2024

Conversation

embik
Copy link
Member

@embik embik commented May 17, 2024

Summary

kubectl-kcp already has a --version flag, but kubectl-workspace does not. This sets the version on the root cmd for kubectl-workspace, mirroring what we do in the other kubectl plugin already.

Related issue(s)

Fixes #

Release Notes

Add `--version` flag to `kubectl-workspace`

@embik
Add version to kubectl-workspace
4efebf7 
Signed-off-by: Marvin Beckers <[email protected]>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. labels May 17, 2024
@embik
Copy link
Member Author

embik commented May 17, 2024

/cc @xrstf

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2024
@kcp-ci-bot kcp-ci-bot requested a review from xrstf May 17, 2024 15:23
palnabarun
palnabarun approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0d49200f76ee9e1b5bb6454466f2111b9b87569

@xrstf
Copy link
Contributor

xrstf commented May 20, 2024

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@kcp-ci-bot kcp-ci-bot merged commit 62229c4 into kcp-dev:main May 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun palnabarun approved these changes

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@embik @kcp-ci-bot @xrstf @palnabarun