🌱 Cleanup last traces of ClusterWorkspaces resource
#3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
cleanup-clusterworkspaces
branch
from
22a03c3
to
ef70050
Compare
embik
changed the title
ClusterWorkspaces resourceClusterWorkspaces resource
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
LGTM label has been added. Git tree hash: befdf344fb96e3c1fd245446c4170700f08b296a
|
embik
changed the title
ClusterWorkspaces resourceClusterWorkspaces resource
kcp-ci-bot
added
the
do-not-merge/work-in-progress
|
changed to WIP to do some further investigation into docs and where to mention |
Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
cleanup-clusterworkspaces
branch
from
ef70050
to
87ec70b
Compare
embik
changed the title
ClusterWorkspaces resourceClusterWorkspaces resource
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
|
/cc @mjudeikis @sttts |
|
I've updated the documentation a bit and mentioned that logical clusters are the backing mechanism now. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 89f0b08bb46e159747f39575003a0b4f2c42bea0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2510, if I understand it correctly, essentially renamed
ClusterWorkspacestoWorkspaces. We still deploy that API type as part of phase 0 though, and our documentation still mentions it.I've removed the last traces of the API resource type by removing the embedded YAMLs and updating the
APIExport.This PR also updates the documentation page for workspaces, removing the "Cluster Workspaces" section and migrating the information that is still relevant (e.g. the URL patterns and workspace types) to the "Workspaces" section.
Also see this Slack thread for a brief discussion of this.
Related issue(s)
Fixes #
Release Notes