Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add krew index build #3094

Merged
merged 5 commits into from
Mar 25, 2024
Merged

✨ add krew index build #3094

merged 5 commits into from
Mar 25, 2024

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Mar 15, 2024 •
edited
Loading

Summary

Related issue(s)

Fixes #

Release Notes

Add krew-index build

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2024
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 15, 2024
embik
embik approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, is KREW_GITHUB_TOKEN already set (i.e. can we merge this PR)?

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3baf7fc71200367e02fa9674e5a7bc0f05e94c1f

@mjudeikis
Copy link
Contributor Author

Fine by me, is KREW_GITHUB_TOKEN already set (i.e. can we merge this PR)?

Set, assuming yaml is right and all works fine :D 🤞

embik
embik approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

🤞🏻

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@kcp-ci-bot kcp-ci-bot merged commit 253afac into kcp-dev:main Mar 25, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjudeikis @kcp-ci-bot @embik