Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove GitHub Actions for image builds #2980

Merged
merged 1 commit into from
Jun 12, 2023
Merged

🌱 Remove GitHub Actions for image builds #2980

merged 1 commit into from
Jun 12, 2023

Conversation

embik
Copy link
Member

@embik embik commented Jun 12, 2023 •
edited
Loading

Summary

After #2976 and kcp-dev/infra#46 have been merged, we can remove the GitHub Actions running for image builds. Especially syncer image builds are no longer needed since TMC was removed in #2963.

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2023
@kcp-ci-bot
Copy link
Contributor

Hi @embik. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@embik
Copy link
Member Author

embik commented Jun 12, 2023

/cc @xrstf

@kcp-ci-bot kcp-ci-bot requested a review from xrstf June 12, 2023 06:52
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 12, 2023
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e15602edbd3fff6b19fbe6967320785ee846544

@embik
Copy link
Member Author

embik commented Jun 12, 2023

/retest

@kcp-ci-bot
Copy link
Contributor

@embik: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor

xrstf commented Jun 12, 2023

/ok-to-test
/retest

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2023
@xrstf
Copy link
Contributor

xrstf commented Jun 12, 2023

This is part of kcp-dev/infra#43

@sttts
Copy link
Member

sttts commented Jun 12, 2023

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@xrstf
Copy link
Contributor

xrstf commented Jun 12, 2023

/retest

1 similar comment
@embik
Copy link
Member Author

embik commented Jun 12, 2023

/retest

@kcp-ci-bot kcp-ci-bot merged commit 66e4e4d into kcp-dev:main Jun 12, 2023
@embik embik deleted the remove-image-action branch June 12, 2023 11:47
@MadhavJivrajani MadhavJivrajani mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@mjudeikis mjudeikis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@embik @kcp-ci-bot @mjudeikis @xrstf @sttts